Hello Sylvain :)

In the panel, Mapbox tiles can't be loaded when using a "non public" token. This is because the Kirby panel (since 3.4) blocks the referrer header (here).

I don't know if this should be an issue with Locator, the Kirby panel or Leaflet.

Locator could circumvent this issue by overriding the meta tag, with something like:

document.querySelector("meta[name=referrer]").content = "origin";

Kirby could solve this by using a less strict referrer policy. Something like "origin" or "no-referrer-when-downgrade"...

Leaflet could solve this by adding a referrer policy to their tiles. Actually they did this a few days ago, but considering their last "release" was in september 2020, I don't know how long it will take to get this option in a stable version...

I will crosspost an issue also on Kirby, and then link here.

While the plugin is correctly installed (and other plugins work fine) I somethow get the following error message with the latest nightly build:

"location" is the field name, not field type, in this case:

fields:
  location:
    type: locator

Hey there, this is somewhat related to #44, because saving a node's osm_id (which is already part of the response data) allows to retrieve the OSM link like that: https://www.openstreetmap.org/node/OSM_ID.

Please consider storing this piece of information, otherwise I'll have to send a duplicate request to get the ID, which would be unnecessary. Please let me know what you think, or how to improve my PR so you might consider merging it.

Cheers, and thank you for this plugin S1SYPHOS

When I put marker on the map, I get lon and lat with dots, like: 58.529276, 1.449215, but when I search for location and save like it's found, output is with comma for one or both, like: 58,529276, 1.449215

Hi,

please follow the kirby composer instructions

Both the type field and the getkirby/composer-installer dependency are required for your plugin to work, otherwise it won't be loaded correctly by Kirby.

The setup with a separate config.php file for Composer is no longer recommended as it can cause issues with the autoloading order. If you put your code directly into the index.php file and don't autoload it with Composer, Kirby will pick it up just fine.

https://getkirby.com/docs/guide/plugins/plugin-setup-basic#the-composer-json

Also what's the purpose of adding the vendor dir to git?

The red bar should be the locator field. When I decrease the indentation of the exact same field (to lift it out of the structure field) it displays and works as expected.

Hi! I tried to install it with composer require sylvainjule/locator on dev-master 3.0.0-beta-6.17. But I get this error:

[InvalidArgumentException]
  Could not find a matching version of package sylvainjule/locator. Check the package spelling, your version constrai
  nt and that the package is available in a stability which matches your minimum-stability (beta).

I'm using Kirby 3.2.2 and getting this error when using the locator field. This is what my blueprint looks like:

title: Location

tabs:
  content:
    label: Content
    icon: document
    columns:
      - width: 2/3
        fields:
          page_content:
            label: Text
            type: textarea
            size: small
          mymap:
            label: Map
            type: locator

First of all thank you for this wonderful plugin.

I'm not sure this is really an issue, but by setting geocoding: mapbox the latitude and longitude values are returned by the toLocation method with a comma and not with a dot.

Nominatim: <?= $location->lat() ?> // 41.894802

Mapbox: <?= $location->lat() ?> // 41,894802

This difference can cause some problems in the frontend implementation of the map.

—

In the content folder the values lat and lon are stored differently between mapbox and nominatim.

Nominatim geocoding:

Map: 

lat: "41.894802"
lon: "12.4853384"
city: Roma
country: Italia

Mapbox geocoding:

Map: 

lat: 41.894802
lon: 12.4853384
city: Roma
country: Italia

Hello, I installed the last version of locator and an error message keeps popping in kirby's panel: "The field type "wathever" does not exist" I tried to change the field name and the massage still is the same, with the new name between the quotation marks. Here is a screenshot of the setup: Normally everything should be fine but as I am learning coding, it could be my mistake... Thank you for your work, it would be great if locator was integrated in kirby, it seems an essential function to me.

This is what I believe to fix #46 – I ran some tests with the default positron maps in my setup and this appears to reliably change the panel's referrerpolicy meta setting to strict-origin-when-cross-origin before tile loading starts (Leaflet tileLayer event loading) and restore the original same-origin policy after loading tiles (tileLayer event load).

The solution is heavily inspired by @rasteiner's workaround and intended as a temporary fix until Leaflet provides proper means to set a referrer policy for fetch. If it proves to work reliably, this is in my opinion the least invasive workaround, as it should not compromise privacy and security for any other fields in the panel (as the policy remains very strict as long as no tile interactions take place).

It would be interesting to hear how this works with the Mapbox API setup and in other environments. The effect can be observed by checking the referrer policy for the tile files in the Devtools Network tab and/or by looking at the meta tag in Inspector view while refreshing/zooming/panning etc.

Feedback and suggestions for improvements most welcome!

In case this is possible from the data we can gather from the geolocation apis, it would be cool to include the country code in the data. This would allow showing a translated country name in the frontend by passing the country code to PHP internals, e.g. Locale::getDisplayRegion.

I've been using this plugin for a handful of sites that include, in some way or another, a collection of multiple pages with locator fields. In the frontend, all pages are output as a set of markers on a full-screen map, each having a popup or linking to a page etc.

I'd like to suggest building an "all locations"-view as an optional panel section. This could display multiple markers on a large map, each marker linking to the respective page in the panel. I know it will come in handy at least for my current/upcoming projects.

Is this something you would consider building/reviewing a pull request for? I'll be working on at least one or two map sites this year, so these projects could justify helping out with such an addition to this plugin.